Use type propagation for removing Smi checks in binary operations and comparisons. Regis will adapt…

runtime/vm/il_printer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/il_printer.h"
 
 #include "vm/intermediate_language.h"
 #include "vm/os.h"
 #include "vm/parser.h"
 
@@ skipping 382 matching lines @@
 void ToDoubleComp::PrintOperandsTo(BufferFormatter* f) const {
   ASSERT(from() == kDoubleCid || from() == kSmiCid);
   f->Print("%s ", from() == kDoubleCid ? "double2double" : "smi2double");
   value()->PrintTo(f);
 }
 
 
 void GraphEntryInstr::PrintTo(BufferFormatter* f) const {
   f->Print("%2d: [graph]", block_id());
   if (start_env_ != NULL) {
+    f->Print("\n{\n");
+    const GrowableArray<Value*>& values = start_env_->values();
+    for (intptr_t i = 0; i < values.length(); i++) {
+      if (values[i]->IsUse()) {
+        Definition* def = values[i]->AsUse()->definition();
+        f->Print("  ", i);
+        def->PrintTo(f);
+        f->Print("\n");
+      }
+    }
+    f->Print("} ");
     start_env_->PrintTo(f);
   }
 }
 
 
 void JoinEntryInstr::PrintTo(BufferFormatter* f) const {
   f->Print("%2d: [join]", block_id());
   if (phis_ != NULL) {
     for (intptr_t i = 0; i < phis_->length(); ++i) {
       if ((*phis_)[i] == NULL) continue;
       f->Print("\n");
       (*phis_)[i]->PrintTo(f);
     }
   }
   if (HasParallelMove()) {
     f->Print("\n");
     parallel_move()->PrintTo(f);
   }
 }
 
 
+static void PrintPropagatedType(BufferFormatter* f, const Definition& def) {
+  if (def.HasPropagatedType()) {
+    String& name = String::Handle();
+    name = AbstractType::Handle(def.PropagatedType()).Name();
+    f->Print(" {PT: %s}", name.ToCString());
+  }
+}
+
 void PhiInstr::PrintTo(BufferFormatter* f) const {
   f->Print("    v%d <- phi(", ssa_temp_index());
   for (intptr_t i = 0; i < inputs_.length(); ++i) {
     if (inputs_[i] != NULL) inputs_[i]->PrintTo(f);
     if (i < inputs_.length() - 1) f->Print(", ");
   }
   f->Print(")");
+  PrintPropagatedType(f, *this);
 }
 
 
 void ParameterInstr::PrintTo(BufferFormatter* f) const {
   f->Print("    v%d <- parameter(%d)",
            HasSSATemp() ? ssa_temp_index() : temp_index(),
            index());

[regis, 2012/08/10 23:18:49]

You should also call PrintPropagatedType(f, *this) here, since it will give you
at least the type of the receiver (and phase parameter in constructors), once I
set them...

[srdjan, 2012/08/10 23:30:05]

Done.

 }
 
 
 void TargetEntryInstr::PrintTo(BufferFormatter* f) const {
   f->Print("%2d: [target", block_id());
   if (HasTryIndex()) {
     f->Print(" catch %d]", try_index());
   } else {
     f->Print("]");
   }
   if (HasParallelMove()) {
     f->Print("\n");
     parallel_move()->PrintTo(f);
   }
 }
 
 
 void BindInstr::PrintTo(BufferFormatter* f) const {
   if (!is_used()) {
     f->Print("    ");
   } else if (HasSSATemp()) {
     f->Print("    v%d <- ", ssa_temp_index());
   } else {
     f->Print("    t%d <- ", temp_index());
   }
   computation()->PrintTo(f);
+  PrintPropagatedType(f, *this);
 }
 
 
 void PushArgumentInstr::PrintTo(BufferFormatter* f) const {
   f->Print("    %s ", DebugName());
   value()->PrintTo(f);
 }
 
 
 void ReturnInstr::PrintTo(BufferFormatter* f) const {
@@ skipping 307 matching lines @@
     if ((locations_ != NULL) && !locations_[i].IsInvalid()) {
       f->Print(" [");
       locations_[i].PrintTo(f);
       f->Print("]");
     }
   }
   f->Print(" }");
 }
 
 }  // namespace dart