Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10823274: Fix two harmless int-to-pointer conversions that a new clang warns about. (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, michaeln
Visibility:
Public.

Description

Fix two harmless int-to-pointer conversions that a new clang warns about. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 4 months ago (2012-08-10 16:48:52 UTC) #1
Avi (use Gerrit)
LGTM
8 years, 4 months ago (2012-08-10 16:56:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10823274/1
8 years, 4 months ago (2012-08-10 17:03:06 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 18:21:23 UTC) #4
Try job failure for 10823274-1 (retry) on linux_rel for step "update".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698