Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 10823266: Fix the Android Eclipse CDT generator. (Closed)

Created:
8 years, 4 months ago by Jesse Greenwald
Modified:
8 years, 3 months ago
Reviewers:
Nico, Satish
CC:
gyp-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

Fix the Android Eclipse CDT generator. This fixes a couple of problems: - CONFIGURATION_NAME is now getting set. This seems to be a required variable now. - Macro values are now escaped before getting written to the XML out in order to handle macros with XML syntax. BUG= gyp r1468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pylib/gyp/generator/eclipse.py View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jesse Greenwald
8 years, 4 months ago (2012-08-09 21:35:38 UTC) #1
Jesse Greenwald
thakis - could you take a look at this fix? Thanks,
8 years, 4 months ago (2012-08-09 21:35:56 UTC) #2
Nico
lgtm, but maybe this suggests that you might want to use a less string-centric approach ...
8 years, 4 months ago (2012-08-09 22:26:14 UTC) #3
Nico
(Do you need me to land this?)
8 years, 4 months ago (2012-08-11 00:37:04 UTC) #4
Jesse Greenwald
On 2012/08/11 00:37:04, Nico wrote: > (Do you need me to land this?) Yes, that ...
8 years, 4 months ago (2012-08-11 00:57:51 UTC) #5
Nico
r1468
8 years, 4 months ago (2012-08-13 22:43:28 UTC) #6
Satish
Does this require a deps roll as well?
8 years, 4 months ago (2012-08-14 22:03:59 UTC) #7
Satish
Should this CL be closed?
8 years, 3 months ago (2012-09-02 22:24:43 UTC) #8
Nico
8 years, 3 months ago (2012-09-04 13:49:18 UTC) #9
On 2012/09/02 22:24:43, Satish wrote:
> Should this CL be closed?

Yes. (By the way, you can close other people's CLs. I went ahead and did that.)

Powered by Google App Engine
This is Rietveld 408576698