Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10823262: Refactoring: Extract gesture event filtering into helper class. (Closed)

Created:
8 years, 4 months ago by rjkroege
Modified:
8 years, 4 months ago
Reviewers:
jam, sadrul, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Refactoring: Extract gesture event filtering into helper class. In the course of writing http://src.chromium.org/viewvc/chrome?view=rev&revision=150463 I noticed that there was getting to be quite a bit of gesture event related code in RenderWidgetHostImpl. This change gathers this code together in an external helper class so that some restructuring needed prior to completing 137555 is easier. This CL should not change any functionality -- only moves code. BUG=137555 TBR=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151063

Patch Set 1 #

Patch Set 2 : fixed proof-reading nits #

Total comments: 2

Patch Set 3 : reviewer nits #

Total comments: 2

Patch Set 4 : more review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -128 lines) Patch
A content/browser/renderer_host/gesture_event_filter.h View 1 2 3 1 chunk +82 lines, -0 lines 0 comments Download
A content/browser/renderer_host/gesture_event_filter.cc View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 4 chunks +3 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 11 chunks +12 lines, -78 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 7 chunks +43 lines, -30 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rjkroege
nits? suggestions?
8 years, 4 months ago (2012-08-09 18:05:59 UTC) #1
sadrul
Very nice! LGTM http://codereview.chromium.org/10823262/diff/2001/content/browser/renderer_host/gesture_event_filter.h File content/browser/renderer_host/gesture_event_filter.h (right): http://codereview.chromium.org/10823262/diff/2001/content/browser/renderer_host/gesture_event_filter.h#newcode5 content/browser/renderer_host/gesture_event_filter.h:5: #ifndef CONTENT_BROWSER_RENDERER_HOST_GESTURE_EVENT_FILTER_ .._FILTER_H_ :)
8 years, 4 months ago (2012-08-09 18:27:43 UTC) #2
rjkroege
https://chromiumcodereview.appspot.com/10823262/diff/2001/content/browser/renderer_host/gesture_event_filter.h File content/browser/renderer_host/gesture_event_filter.h (right): https://chromiumcodereview.appspot.com/10823262/diff/2001/content/browser/renderer_host/gesture_event_filter.h#newcode5 content/browser/renderer_host/gesture_event_filter.h:5: #ifndef CONTENT_BROWSER_RENDERER_HOST_GESTURE_EVENT_FILTER_ On 2012/08/09 18:27:43, sadrul wrote: > .._FILTER_H_ ...
8 years, 4 months ago (2012-08-09 19:59:12 UTC) #3
rjkroege
sky@ for OWNERS please?
8 years, 4 months ago (2012-08-09 21:00:26 UTC) #4
sky
LGTM https://chromiumcodereview.appspot.com/10823262/diff/8/content/browser/renderer_host/gesture_event_filter.h File content/browser/renderer_host/gesture_event_filter.h (right): https://chromiumcodereview.appspot.com/10823262/diff/8/content/browser/renderer_host/gesture_event_filter.h#newcode16 content/browser/renderer_host/gesture_event_filter.h:16: using WebKit::WebGestureEvent; No using in headers.
8 years, 4 months ago (2012-08-09 21:42:52 UTC) #5
rjkroege
https://chromiumcodereview.appspot.com/10823262/diff/8/content/browser/renderer_host/gesture_event_filter.h File content/browser/renderer_host/gesture_event_filter.h (right): https://chromiumcodereview.appspot.com/10823262/diff/8/content/browser/renderer_host/gesture_event_filter.h#newcode16 content/browser/renderer_host/gesture_event_filter.h:16: using WebKit::WebGestureEvent; On 2012/08/09 21:42:52, sky wrote: > No ...
8 years, 4 months ago (2012-08-10 15:12:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10823262/4003
8 years, 4 months ago (2012-08-10 15:12:58 UTC) #7
commit-bot: I haz the power
Presubmit check for 10823262-4003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-10 15:13:07 UTC) #8
rjkroege
+ jam for OWNERS on TBR'd change to gypi file.
8 years, 4 months ago (2012-08-10 15:34:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10823262/4003
8 years, 4 months ago (2012-08-10 15:35:18 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 17:09:00 UTC) #11
Change committed as 151063

Powered by Google App Engine
This is Rietveld 408576698