Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Issue 10823251: Setuid sandbox unittest: fix environment. (Closed)

Created:
8 years, 4 months ago by jln (very slow on Chromium)
Modified:
8 years, 4 months ago
Reviewers:
Markus (顧孟勤)
CC:
chromium-reviews, agl, jln+watch_chromium.org, Jorge Lucangeli Obes
Visibility:
Public.

Description

Setuid sandbox unittest: fix environment. Don't pollute LD_PRELOAD in the environment after a test runs. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M sandbox/linux/suid/client/setuid_sandbox_client_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
Oops! Jorge got quite puzzled when he got LD_PRELOAD related error messages while running some ...
8 years, 4 months ago (2012-08-09 01:52:47 UTC) #1
Markus (顧孟勤)
I thought tests can run in parallel on our bots. Or am I confused -- ...
8 years, 4 months ago (2012-08-09 02:12:10 UTC) #2
jln (very slow on Chromium)
On 2012/08/09 02:12:10, Markus (顧孟勤) wrote: > I thought tests can run in parallel on ...
8 years, 4 months ago (2012-08-09 02:22:09 UTC) #3
Markus (顧孟勤)
lgtm
8 years, 4 months ago (2012-08-09 03:11:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/10823251/1
8 years, 4 months ago (2012-08-09 03:19:59 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 05:18:29 UTC) #6
Change committed as 150739

Powered by Google App Engine
This is Rietveld 408576698