Issue 10823246: VAVDA: Fix a crash if we fail parsing SPS/DecodeInitial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823246: VAVDA: Fix a crash if we fail parsing SPS/DecodeInitial. (Closed)

Created:
8 years, 4 months ago by Pawel Osciak

Modified:
8 years, 4 months ago

Reviewers:
marcheu, Ami GONE FROM CHROMIUM, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org

Base URL:
https://git.chromium.org/git/chromium/src@master

Visibility:
Public.

More Reviews

Description

VAVDA: Fix a crash if we fail parsing SPS/DecodeInitial. If SPS has unsupported parameters, we get overzealous by attempting to destroy a not-yet-created VA context causing a crash in the driver. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150712

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	content/common/gpu/media/vaapi_h264_decoder.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/common/gpu/media/vaapi_h264_decoder.cc	View		3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

marcheu

On 2012/08/09 01:08:23, posciak wrote: LGTM. I wish there was an "invalid context id" in ...

8 years, 4 months ago (2012-08-09 01:10:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/10823246/1

8 years, 4 months ago (2012-08-09 01:17:39 UTC) #5

Change committed as 150712

Expand Messages | Collapse Messages