Issue 10823243: Fix crash in bundle install dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823243: Fix crash in bundle install dialog. (Closed)

Created:
8 years, 4 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash in bundle install dialog. r149688 added a check for the extension type in ExtensionInstallPrompt::ShowConfirmation, but for bundle installs we don't have an Extension instance to get the type of. BUG=141451 R=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150724

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/extensions/extension_install_prompt.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_install_prompt.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10823243/1

8 years, 4 months ago (2012-08-09 00:17:47 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-08-09 02:07:25 UTC) #4

Try job failure for 10823243-1 (retry) (retry) on linux_rel for step
"nacl_integration".
It's a second try, previously, step "nacl_integration" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages