Roll libjingle 165:168

Roll libjingle 165:168

- Fixed the issue on PeerConnection offer rejection.
- Factored out the usage of cricket::CaptureResult.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150717

[Wez, 2012-08-08 23:48:44]

What does this roll get us? :)

[Ronghua Wu (Left Chromium), 2012-08-08 23:51:14]

LGTM

You may use some information from:
http://code.google.com/p/libjingle/source/diff?spec=svn166&r=166&format=side&...

[Sergey Ulanov, 2012-08-08 23:57:57]

On 2012/08/08 23:48:44, Wez wrote:
> What does this roll get us? :)

Updated description.
But I don't think adding list of changes in each roll is a very useful practice:
such descriptions have high probability of being incomplete (unless we have
tools to generate them automatically), and in the same time whoever needs this
information can always look at the list of changes upstream.
Also most other dependencies (WebKit, Skia) never document list of changes for
each roll.

[Wez, 2012-08-09 00:00:09]

On 2012/08/08 23:57:57, sergeyu wrote:
> On 2012/08/08 23:48:44, Wez wrote:
> > What does this roll get us? :)
> 
> Updated description.
> But I don't think adding list of changes in each roll is a very useful
practice:
> such descriptions have high probability of being incomplete (unless we have
> tools to generate them automatically), and in the same time whoever needs this
> information can always look at the list of changes upstream.
> Also most other dependencies (WebKit, Skia) never document list of changes for
> each roll.

I agree; I was thinking more of a link like the one Ronghua provided, to the
changes in the originating project's release notes, and possibly a mention of
which specific change we made this roll to get, if any.

LGTM, though. :)

[commit-bot: I haz the power, 2012-08-09 00:17:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10823242/1

[commit-bot: I haz the power, 2012-08-09 02:13:17]

Try job failure for 10823242-1 (retry) (retry) (retry) on linux_rel for step
"nacl_integration".
It's a second try, previously, step "nacl_integration" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-09 02:16:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10823242/1

[commit-bot: I haz the power, 2012-08-09 04:00:06]

Change committed as 150717