Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 10823239: Upstream android's fling animator. (Closed)

Created:
8 years, 4 months ago by Nate Chapin
Modified:
8 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Upstream android's fling animator. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151327

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
A webkit/glue/fling_animator_impl_android.h View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A webkit/glue/fling_animator_impl_android.cc View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nate Chapin
This can't be landed until DEPS rolls past http://trac.webkit.org/changeset/125061
8 years, 4 months ago (2012-08-08 22:19:36 UTC) #1
jamesr
lgtm http://chromiumcodereview.appspot.com/10823239/diff/8001/webkit/glue/fling_animator_impl_android.cc File webkit/glue/fling_animator_impl_android.cc (right): http://chromiumcodereview.appspot.com/10823239/diff/8001/webkit/glue/fling_animator_impl_android.cc#newcode81 webkit/glue/fling_animator_impl_android.cc:81: env->CallIntMethod(java_scroller_.obj(), getY_method_id_)); indentation here seems wrong somehow - ...
8 years, 4 months ago (2012-08-09 00:03:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/10823239/5002
8 years, 4 months ago (2012-08-13 18:31:07 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 19:45:15 UTC) #4
Change committed as 151327

Powered by Google App Engine
This is Rietveld 408576698