Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: media/tools/layout_tests/layouttest_analyzer_helpers.py

Issue 10823238: Don't count SLOW tests towards failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/tools/layout_tests/layouttest_analyzer_helpers.py
diff --git a/media/tools/layout_tests/layouttest_analyzer_helpers.py b/media/tools/layout_tests/layouttest_analyzer_helpers.py
index 7a133d085420f1312bd75c3bb25f5453d98ce197..6193dfa41f6610f80ad58dd4421a96ddda28b144 100644
--- a/media/tools/layout_tests/layouttest_analyzer_helpers.py
+++ b/media/tools/layout_tests/layouttest_analyzer_helpers.py
@@ -63,7 +63,8 @@ class AnalyzerResultMap:
for (k, value) in test_info_map.iteritems():
self.result_map['whole'][k] = value
if 'te_info' in value:
- if any([True for x in value['te_info'] if 'SKIP' in x]):
+ if any([True for x in value['te_info']
+ if 'SKIP' in x or 'SLOW' in x]):
Ami GONE FROM CHROMIUM 2012/08/08 20:32:27 A SLOW line that has anything to the right of the
DaleCurtis 2012/08/08 20:53:54 Just PASS? Or PASS + modifiers? There are several
Ami GONE FROM CHROMIUM 2012/08/08 20:57:09 If there's anything other than PASS to the right o
DaleCurtis 2012/08/08 23:47:25 Done. Although no tests now qualify for SLOW curre
self.result_map['skip'][k] = value
else:
self.result_map['nonskip'][k] = value
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698