chrome/browser/ui/browser_command_controller.cc - Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win compilation fixed Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index c6c553b13f75dd558ef067d986bdddc10fd05177..fec9e70e9c0452226e43943115679b03ef3c23aa 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -488,7 +488,7 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

CreateApplicationShortcuts(browser_);

break;

case IDC_DEV_TOOLS:

- ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_NONE);

+ ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW);

break;

case IDC_DEV_TOOLS_CONSOLE:

ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);

@@ -496,6 +496,9 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

case IDC_DEV_TOOLS_INSPECT:

ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_INSPECT);

break;

+ case IDC_DEV_TOOLS_TOGGLE:

+ ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_TOGGLE);

+ break;

case IDC_TASK_MANAGER:

OpenTaskManager(browser_, false);

break;

@@ -930,6 +933,8 @@ void BrowserCommandController::UpdateCommandsForDevTools() {

dev_tools_enabled);

command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS_INSPECT,

dev_tools_enabled);

+ command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS_TOGGLE,

+ dev_tools_enabled);

}

void BrowserCommandController::UpdateCommandsForBookmarkEditing() {

« no previous file with comments | « chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »