Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/browser/debugger/devtools_window.h

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win compilation fixed Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_toggle_action.h ('k') | chrome/browser/debugger/devtools_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_window.h
diff --git a/chrome/browser/debugger/devtools_window.h b/chrome/browser/debugger/devtools_window.h
index dfe73ab8d141e5e3d995312c72c30f54dd1a1197..ef5cc38de0e60e156070a6fe9bac8cd166f288c7 100644
--- a/chrome/browser/debugger/devtools_window.h
+++ b/chrome/browser/debugger/devtools_window.h
@@ -57,7 +57,13 @@ class DevToolsWindow : private content::NotificationObserver,
static DevToolsWindow* OpenDevToolsWindow(
content::RenderViewHost* inspected_rvh);
static DevToolsWindow* ToggleDevToolsWindow(
+ Browser* browser,
+ DevToolsToggleAction action);
+
+ // Exposed for testing, normal clients should not use this method.
+ static DevToolsWindow* ToggleDevToolsWindow(
content::RenderViewHost* inspected_rvh,
+ bool force_open,
DevToolsToggleAction action);
static void InspectElement(
content::RenderViewHost* inspected_rvh, int x, int y);
@@ -129,11 +135,8 @@ class DevToolsWindow : private content::NotificationObserver,
virtual void FrameNavigating(const std::string& url) OVERRIDE {}
- static DevToolsWindow* ToggleDevToolsWindow(
- content::RenderViewHost* inspected_rvh,
- bool force_open,
- DevToolsToggleAction action);
static DevToolsWindow* AsDevToolsWindow(content::DevToolsClientHost*);
+ static DevToolsWindow* AsDevToolsWindow(content::RenderViewHost*);
// content::DevToolsClientHandlerDelegate overrides.
virtual void ActivateWindow() OVERRIDE;
« no previous file with comments | « chrome/browser/debugger/devtools_toggle_action.h ('k') | chrome/browser/debugger/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698