Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 10823232: Truncate address in amd64_nacl_software_single_step. If breakpoint is set to untruncated address, i… (Closed)

Created:
8 years, 4 months ago by halyavin
Modified:
8 years, 4 months ago
Reviewers:
eaeltsin, khim
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master
Visibility:
Public.

Description

Truncate address in amd64_nacl_software_single_step. If breakpoint is set to untruncated address, it is not recognized by gdb as its own breakpoint. When the breakpoint is hit, rip is not decreased and so execution starts from the middle of the instruction. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2947 TEST= https://chromiumcodereview.appspot.com/10826183/ R=khim@chromium.com,eaeltsin@google.com Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=1e4c87f

Patch Set 1 #

Patch Set 2 : update description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gdb/nacl-tdep.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
halyavin
8 years, 4 months ago (2012-08-08 13:18:56 UTC) #1
khim
8 years, 4 months ago (2012-08-09 12:13:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698