Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 10823213: Change default wallpaper. (Closed)

Created:
8 years, 4 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 4 months ago
Reviewers:
Nikita (slow), bshe, sky
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Change default wallpaper. BUG=140072 TBR=nkostylev@chromium.org (for chrome/browser/chromeos/login/wallpaper_manager.cc), sky for the rest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150462

Patch Set 1 #

Patch Set 2 : guest has same default wp. #

Patch Set 3 : fix for 141222 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M ash/desktop_background/desktop_background_resources.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/ui_resources.grd View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Emmanuel Saint-loubert-Bié
Biao, Please take a look. -- Emmanuel
8 years, 4 months ago (2012-08-07 21:13:54 UTC) #1
bshe
On 2012/08/07 21:13:54, Emmanuel Saint-loubert-Bié wrote: > Biao, > > Please take a look. > ...
8 years, 4 months ago (2012-08-07 21:39:13 UTC) #2
Emmanuel Saint-loubert-Bié
Scott, Please review as OWNER -- Emmanuel
8 years, 4 months ago (2012-08-07 21:49:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/10823213/9002
8 years, 4 months ago (2012-08-07 22:43:29 UTC) #4
sky
LGTM
8 years, 4 months ago (2012-08-07 23:17:32 UTC) #5
commit-bot: I haz the power
Change committed as 150462
8 years, 4 months ago (2012-08-08 00:04:10 UTC) #6
Nikita (slow)
8 years, 4 months ago (2012-08-08 05:51:16 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698