Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823212: Relanding this as this did not fix the chromiumos breakage. (Closed)

Created:
8 years, 4 months ago by ananta
Modified:
8 years, 4 months ago
Reviewers:
ananta
CC:
chromium-reviews, ncarter (slow), nkostylev+watch_chromium.org, Raghu Simha, davemoore+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, tim (not reviewing), akalin
Visibility:
Public.

Description

Relanding this as this did not fix the chromiumos breakage. Revert 150391 - Reverting this as it causes browser tests on the Linux ChromiumOS builder to fail. Will revert back if it does not address the redness. Revert 150380 - Add support for loading user cloud policy on desktop, behind the --load-cloud-policy-on-signin flag. Move UserCloudPolicyManager to be owned by the Profile as a step towards supporting multiple profiles. Added TestingProfile::Builder as a start towards taming the madness of all the different constructors and setters. BUG=141123 TEST=none Review URL: https://chromiumcodereview.appspot.com/10693022 TBR=atwilson@chromium.org Review URL: https://chromiumcodereview.appspot.com/10823208 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -224 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/policy_oauth_fetcher.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/policy/auto_enrollment_client.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.h View 4 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 13 chunks +118 lines, -91 lines 0 comments Download
M chrome/browser/policy/cloud_policy_client.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud_policy_provider.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/policy/cloud_policy_store.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/policy/cloud_policy_subsystem.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_subsystem.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_loader.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager.h View 2 chunks +20 lines, -10 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager.cc View 2 chunks +17 lines, -16 lines 0 comments Download
A + chrome/browser/policy/user_cloud_policy_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_cloud_policy_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_cloud_policy_store_base.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_cloud_policy_store_base.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_store_chromeos.h View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_store_chromeos.cc View 5 chunks +41 lines, -24 lines 0 comments Download
A + chrome/browser/policy/user_cloud_policy_store_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_policy_signin_service.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_policy_signin_service.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_policy_signin_service_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_policy_signin_service_factory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/policy/user_policy_signin_service_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +2 lines, -0 lines 0 comments Download
MM chrome/browser/prefs/pref_member.cc View 2 chunks +3 lines, -2 lines 0 comments Download
MM chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
MM chrome/browser/profiles/profile.h View 3 chunks +6 lines, -1 line 0 comments Download
MM chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +5 lines, -0 lines 0 comments Download
MM chrome/browser/profiles/profile_impl.h View 2 chunks +7 lines, -3 lines 0 comments Download
MM chrome/browser/profiles/profile_impl.cc View 3 chunks +15 lines, -3 lines 0 comments Download
MM chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/browser/signin/signin_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
MM chrome/browser/signin/signin_manager_fake.h View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/signin/signin_manager_fake.cc View 2 chunks +11 lines, -2 lines 0 comments Download
MM chrome/browser/sync/profile_sync_service_mock.cc View 2 chunks +2 lines, -9 lines 0 comments Download
MM chrome/browser/sync/sync_ui_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
MM chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
MM chrome/chrome_browser.gypi View 2 chunks +14 lines, -0 lines 0 comments Download
MM chrome/chrome_tests.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
MM chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
MM chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download
MM chrome/test/base/testing_browser_process.cc View 4 chunks +18 lines, -6 lines 0 comments Download
MM chrome/test/base/testing_profile.h View 5 chunks +64 lines, -0 lines 0 comments Download
MM chrome/test/base/testing_profile.cc View 5 chunks +112 lines, -24 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
8 years, 4 months ago (2012-08-07 21:09:36 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698