Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: runtime/vm/virtual_memory_android.cc

Issue 10823209: Add support for building the Dart VM for Android OS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address cshapiro's review comments, pass 2 Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/virtual_memory_android.cc
diff --git a/runtime/vm/virtual_memory_linux.cc b/runtime/vm/virtual_memory_android.cc
similarity index 97%
copy from runtime/vm/virtual_memory_linux.cc
copy to runtime/vm/virtual_memory_android.cc
index 189c0fc4c9b6cd58d8ca3d2a27ffb73b50a027e7..74f43a294a540d9f60137836f05f34ef744570f9 100644
--- a/runtime/vm/virtual_memory_linux.cc
+++ b/runtime/vm/virtual_memory_android.cc
@@ -5,7 +5,6 @@
#include "vm/virtual_memory.h"
#include <sys/mman.h>
-#include <sys/unistd.h>
#include <unistd.h>
#include "platform/assert.h"
@@ -27,6 +26,7 @@ void VirtualMemory::InitOnce() {
VirtualMemory* VirtualMemory::Reserve(intptr_t size) {
+ // TODO(4480): use ashmem instead of anonymous memory
Emily Fortuna 2012/08/08 01:28:37 Generally the TODO messages contain a person's lda
cshapiro 2012/08/08 02:57:42 I think this is just a simple transposition error.
jackpal 2012/08/08 23:06:45 Done.
void* address = mmap(NULL, size, PROT_NONE,
MAP_PRIVATE | MAP_ANON | MAP_NORESERVE,
-1, 0);

Powered by Google App Engine
This is Rietveld 408576698