runtime/vm/os_android.cc - Issue 10823209: Add support for building the Dart VM for Android OS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/os_android.cc

Issue 10823209: Add support for building the Dart VM for Android OS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Incorporate review feedback from cshapiro Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/os.h"	5 #include "vm/os.h"

6	6

7 #include <errno.h>	7 #include <errno.h>

8 #include <limits.h>	8 #include <limits.h>

9 #include <time.h>	9 #include <time.h>

10 #include <sys/resource.h>	10 #include <sys/resource.h>

(...skipping 186 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
197 ASSERT(init_once_called == false);	197 ASSERT(init_once_called == false);

198 init_once_called = true;	198 init_once_called = true;

199 }	199 }

200	200

201	201

202 void OS::Shutdown() {	202 void OS::Shutdown() {

203 }	203 }

204	204

205	205

206 void OS::Abort() {	206 void OS::Abort() {

207 abort();	207 abort();
	cshapiro 2012/08/07 22:39:40 I would like this to interact well with the Androi I would like this to interact well with the Android debuggerd so nice traces can be reported and the debugger can attach to the victim thread. If this already works, we are okay. Otherwise, it would be useful to fix that, or leave a TODO and file a bug.
208 }	208 }

209	209

210	210

211 void OS::Exit(int code) {	211 void OS::Exit(int code) {

212 exit(code);	212 exit(code);

213 }	213 }

214	214

215 } // namespace dart	215 } // namespace dart

OLD	NEW

« runtime/bin/socket_android.cc ('K') | « runtime/vm/gdbjit_android.cc ('k') | runtime/vm/virtual_memory_android.cc » ('j') | tools/android-build.sh » ('J')