Add support for building the Dart VM for Android OS.

runtime/bin/directory_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <sys/param.h>
 #include <sys/stat.h>
@@ skipping 358 matching lines @@
     ASSERT(errno == ELOOP ||
            errno == ENAMETOOLONG ||
            errno == ENOENT ||
            errno == ENOTDIR);
     return DOES_NOT_EXIST;
   }
 }
 
 
 char* Directory::Current() {
-  return getcwd(NULL, 0);
+  // Android's getcwd adheres closely to the POSIX standard. It won't
+  // allocate memory. We need to make our own copy.
+
+  char buffer[PATH_MAX];
+  if (NULL == getcwd(buffer, PATH_MAX)) {
+    return NULL;
+  }
+
+  size_t length = strlen(buffer);

[cshapiro, 2012/08/07 20:56:54]

Instead of all of this code, would a single call to strdup be good enough?  You
have to call free anyway, so it is interface compatible.

[jackpal, 2012/08/07 21:43:26]

Done.

+  char* result = reinterpret_cast<char*>(malloc(length + 1));
+  if (result == NULL) {
+    return NULL;
+  }
+
+  strncpy(result, buffer, length);
+  result[length] = '\0';
+  return result;
 }
 
 
 bool Directory::Create(const char* dir_name) {
   // Create the directory with the permissions specified by the
   // process umask.
   return (TEMP_FAILURE_RETRY(mkdir(dir_name, 0777)) == 0);
 }
 
+// Android doesn't currenpty provide mkdtemp
+

[cshapiro, 2012/08/07 20:56:54]

No need for an empty line here.

[jackpal, 2012/08/07 21:43:26]

Done.

+static char* android_mkdtemp(char* _template) {

[cshapiro, 2012/08/07 20:56:54]

This should be named Mkdtemp or something else that is closer to the prevalent
naming convention.

[jackpal, 2012/08/07 21:43:26]

Done.

+  printf("mkdtemp %s\n", _template);
+  if (mktemp(_template) == NULL) {
+    printf("mktemp failed\n");
+    return NULL;
+  }
+  if (mkdir(_template, 0700) != 0) {
+    printf("mkdir failed\n");
+    return NULL;
+  }
+  printf("Success\n");
+  return _template;
+}
 
 char* Directory::CreateTemp(const char* const_template) {
   // Returns a new, unused directory name, modifying the contents of
   // dir_template.  Creates the directory with the permissions specified
   // by the process umask.
   // The return value must be freed by the caller.
   char* path = static_cast<char*>(malloc(PATH_MAX + 1));
   SafeStrNCpy(path, const_template, PATH_MAX + 1);
   int path_length = strlen(path);
   if (path_length > 0) {
     if ((path)[path_length - 1] == '/') {
       snprintf(path + path_length, PATH_MAX - path_length, "temp_dir_XXXXXX");
     } else {
       snprintf(path + path_length, PATH_MAX - path_length, "XXXXXX");
     }
   } else {
     snprintf(path, PATH_MAX, "/tmp/temp_dir1_XXXXXX");
   }
   char* result;
   do {
-    result = mkdtemp(path);
+    result = android_mkdtemp(path);

[cshapiro, 2012/08/07 20:56:54]

ditto

[jackpal, 2012/08/07 21:43:26]

Done.

   } while (result == NULL && errno == EINTR);
   if (result == NULL) {
     free(path);
     return NULL;
   }
   return path;
 }
 

[cshapiro, 2012/08/07 20:56:54]

Definitions are separated by 2 spaces.  You should probably add this back.

[jackpal, 2012/08/07 21:43:26]

Done.

-
 bool Directory::Delete(const char* dir_name, bool recursive) {
   if (!recursive) {
     return (TEMP_FAILURE_RETRY(remove(dir_name)) == 0);
   } else {
     return DeleteRecursively(dir_name);
   }
 }
 
 
 bool Directory::Rename(const char* path, const char* new_path) {
   ExistsResult exists = Exists(path);
   if (exists != EXISTS) return false;
   return (TEMP_FAILURE_RETRY(rename(path, new_path)) == 0);
 }