Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3386)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler_unittest.cc

Issue 10823208: Reverting this as it causes browser tests on the Linux ChromiumOS builder to fail. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_handler_unittest.cc
===================================================================
--- chrome/browser/ui/webui/sync_setup_handler_unittest.cc (revision 150390)
+++ chrome/browser/ui/webui/sync_setup_handler_unittest.cc (working copy)
@@ -341,12 +341,12 @@
class SigninManagerMock : public FakeSigninManager {
public:
- explicit SigninManagerMock(Profile* profile) : FakeSigninManager(profile) {}
+ SigninManagerMock() {}
MOCK_CONST_METHOD1(IsAllowedUsername, bool(const std::string& username));
};
static ProfileKeyedService* BuildSigninManagerMock(Profile* profile) {
- return new SigninManagerMock(profile);
+ return new SigninManagerMock();
}
// The boolean parameter indicates whether the test is run with ClientOAuth
@@ -367,6 +367,7 @@
error_ = GoogleServiceAuthError::None();
profile_.reset(ProfileSyncServiceMock::MakeSignedInTestingProfile());
+ SyncPromoUI::RegisterUserPrefs(profile_->GetPrefs());
mock_pss_ = static_cast<ProfileSyncServiceMock*>(
ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
profile_.get(),
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698