chrome/browser/sync/sync_ui_util_unittest.cc - Issue 10823208: Reverting this as it causes browser tests on the Linux ChromiumOS builder to fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_ui_util_unittest.cc

Issue 10823208: Reverting this as it causes browser tests on the Linux ChromiumOS builder to fail. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_mock.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sync_ui_util_unittest.cc

===================================================================

--- chrome/browser/sync/sync_ui_util_unittest.cc (revision 150390)

+++ chrome/browser/sync/sync_ui_util_unittest.cc (working copy)

@@ -78,7 +78,7 @@

scoped_ptr<Profile> profile(

ProfileSyncServiceMock::MakeSignedInTestingProfile());

NiceMock<ProfileSyncServiceMock> service(profile.get());

- FakeSigninManager signin(profile.get());

+ FakeSigninManager signin;

browser_sync::SyncBackendHost::Status status;

EXPECT_CALL(service, QueryDetailedSyncStatus(_))

.WillRepeatedly(Return(false));

@@ -99,7 +99,7 @@

scoped_ptr<Profile> profile(

ProfileSyncServiceMock::MakeSignedInTestingProfile());

NiceMock<ProfileSyncServiceMock> service(profile.get());

- FakeSigninManager signin(profile.get());

+ FakeSigninManager signin;

browser_sync::SyncBackendHost::Status status;

EXPECT_CALL(service, QueryDetailedSyncStatus(_))

.WillRepeatedly(Return(false));

@@ -153,7 +153,7 @@

{ GoogleServiceAuthError::HOSTED_NOT_ALLOWED, true },

};

- FakeSigninManager signin(profile.get());

+ FakeSigninManager signin;

for (size_t i = 0; i < sizeof(table)/sizeof(*table); ++i) {

VerifySyncGlobalErrorResult(

&service, signin, table[i].error_state, true, table[i].is_error);

« no previous file with comments | « chrome/browser/sync/profile_sync_service_mock.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | no next file with comments »