Issue 10823202: Add heap space sizes and external memory counter to V8 statistics extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823202: Add heap space sizes and external memory counter to V8 statistics extension. (Closed)

Created:
8 years, 4 months ago by ulan

Modified:
8 years, 4 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add heap space sizes and external memory counter to V8 statistics extension. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12272

Patch Set 1 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -18 lines)			Patch
	M	src/extensions/statistics-extension.cc	View		2 chunks	+64 lines, -18 lines	1 comment	Download
	M	src/heap.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 4 months ago (2012-08-07 15:13:04 UTC) #2

LGTM with comment.

https://chromiumcodereview.appspot.com/10823202/diff/2001/src/extensions/stat...
File src/extensions/statistics-extension.cc (right):

https://chromiumcodereview.appspot.com/10823202/diff/2001/src/extensions/stat...
src/extensions/statistics-extension.cc:142:
"amount_of_external_allocated_memory");
It seems to me that a macro would save a lot of space since Size(), Available()
and CommittedMemory() are used repeatedly.

Expand Messages | Collapse Messages