Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10823201: Fixing bug in updating file list in save-as dialog. (Closed)

Created:
8 years, 4 months ago by SeRya
Modified:
8 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fixing bug in updating file list in save-as dialog. Problem occuired because file manager code uses the selectedIndexes property of selectionModel. But setter for this methos is implemented only for multi-selection list, but not fo single selection (which is used in the save-as dialog). It fails to restore selection and consequently fails to restore lead item. Resetting lead item stops renaming. BUG=138975 TEST=Manual test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151200

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
SeRya
8 years, 4 months ago (2012-08-07 14:33:32 UTC) #1
Oleg Eterevsky
lgtm
8 years, 4 months ago (2012-08-07 14:55:25 UTC) #2
arv (Not doing code reviews)
lgtm https://chromiumcodereview.appspot.com/10823201/diff/1/chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js File chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js (right): https://chromiumcodereview.appspot.com/10823201/diff/1/chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js#newcode44 chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js:44: set selectedIndexes(value) { s/value/indexes/
8 years, 4 months ago (2012-08-07 17:10:30 UTC) #3
SeRya
http://codereview.chromium.org/10823201/diff/1/chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js File chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js (right): http://codereview.chromium.org/10823201/diff/1/chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js#newcode44 chrome/browser/resources/shared/js/cr/ui/list_single_selection_model.js:44: set selectedIndexes(value) { On 2012/08/07 17:10:30, arv wrote: > ...
8 years, 4 months ago (2012-08-09 17:37:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10823201/6001
8 years, 4 months ago (2012-08-09 17:37:13 UTC) #5
commit-bot: I haz the power
Try job failure for 10823201-6001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-09 18:46:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10823201/6001
8 years, 4 months ago (2012-08-12 10:33:00 UTC) #7
commit-bot: I haz the power
Try job failure for 10823201-6001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-12 11:50:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10823201/6001
8 years, 4 months ago (2012-08-12 13:38:23 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-12 14:53:29 UTC) #10
Change committed as 151200

Powered by Google App Engine
This is Rietveld 408576698