Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823197: app_list: Fix the header include guards. (Closed)

Created:
8 years, 4 months ago by tfarina
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M chrome/browser/ui/ash/app_list/app_list_view_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/apps_model_builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/chrome_app_list_item.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/app_list/extension_app_item.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/search_builder.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
TBRing...
8 years, 4 months ago (2012-08-07 01:47:18 UTC) #1
Ben Goodger (Google)
8 years, 4 months ago (2012-08-07 01:55:56 UTC) #2 
lgtm


On Mon, Aug 6, 2012 at 6:47 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
> Description:
> app_list: Fix the header include guards.
>
> BUG=125846
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10823197/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/ui/ash/app_**list/app_list_view_delegate.h
>   M chrome/browser/ui/ash/app_**list/apps_model_builder.h
>   M chrome/browser/ui/ash/app_**list/chrome_app_list_item.h
>   M chrome/browser/ui/ash/app_**list/extension_app_item.h
>   M chrome/browser/ui/ash/app_**list/search_builder.h
>
>
> Index: chrome/browser/ui/ash/app_**list/app_list_view_delegate.h
> diff --git a/chrome/browser/ui/ash/app_**list/app_list_view_delegate.h
> b/chrome/browser/ui/ash/app_**list/app_list_view_delegate.h
> index 105b284f555bd52b3be70f0af12a21**4a08dd4505..**
> 7dd72dae0ed62db16ddcba81c73848**161a8078c7 100644
> --- a/chrome/browser/ui/ash/app_**list/app_list_view_delegate.h
> +++ b/chrome/browser/ui/ash/app_**list/app_list_view_delegate.h
> @@ -2,8 +2,8 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_APP_LIST_VIEW_**
> DELEGATE_H_
> -#define CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_APP_LIST_VIEW_**
> DELEGATE_H_
> +#ifndef CHROME_BROWSER_UI_ASH_APP_**LIST_APP_LIST_VIEW_DELEGATE_H_
> +#define CHROME_BROWSER_UI_ASH_APP_**LIST_APP_LIST_VIEW_DELEGATE_H_
>
>  #include <string>
>
> @@ -37,4 +37,4 @@ class AppListViewDelegate : public
> app_list::AppListViewDelegate {
>    DISALLOW_COPY_AND_ASSIGN(**AppListViewDelegate);
>  };
>
> -#endif  // CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_APP_LIST_VIEW_**
> DELEGATE_H_
> +#endif  // CHROME_BROWSER_UI_ASH_APP_**LIST_APP_LIST_VIEW_DELEGATE_H_
> Index: chrome/browser/ui/ash/app_**list/apps_model_builder.h
> diff --git a/chrome/browser/ui/ash/app_**list/apps_model_builder.h
> b/chrome/browser/ui/ash/app_**list/apps_model_builder.h
> index b756e1ef6bb965b43cd25fd7a1c443**48c7e2b6db..**
> 65c3b656531970ae0eace7d76923bb**cee94e6ed6 100644
> --- a/chrome/browser/ui/ash/app_**list/apps_model_builder.h
> +++ b/chrome/browser/ui/ash/app_**list/apps_model_builder.h
> @@ -2,8 +2,8 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_APPS_MODEL_BUILDER_H_
> -#define CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_APPS_MODEL_BUILDER_H_
> +#ifndef CHROME_BROWSER_UI_ASH_APP_**LIST_APPS_MODEL_BUILDER_H_
> +#define CHROME_BROWSER_UI_ASH_APP_**LIST_APPS_MODEL_BUILDER_H_
>
>  #include <string>
>  #include <vector>
> @@ -66,4 +66,4 @@ class AppsModelBuilder : public
> content::NotificationObserver {
>    DISALLOW_COPY_AND_ASSIGN(**AppsModelBuilder);
>  };
>
> -#endif  // CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_APPS_MODEL_BUILDER_H_
> +#endif  // CHROME_BROWSER_UI_ASH_APP_**LIST_APPS_MODEL_BUILDER_H_
> Index: chrome/browser/ui/ash/app_**list/chrome_app_list_item.h
> diff --git a/chrome/browser/ui/ash/app_**list/chrome_app_list_item.h
> b/chrome/browser/ui/ash/app_**list/chrome_app_list_item.h
> index 976e4d8a366c7421dd8cf31ef7142f**6e9b670376..**
> 0beca111448e4dba14b037c02f0b1b**7a91554031 100644
> --- a/chrome/browser/ui/ash/app_**list/chrome_app_list_item.h
> +++ b/chrome/browser/ui/ash/app_**list/chrome_app_list_item.h
> @@ -2,8 +2,8 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_CHROME_APP_LIST_ITEM_**H_
> -#define CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_CHROME_APP_LIST_ITEM_**H_
> +#ifndef CHROME_BROWSER_UI_ASH_APP_**LIST_CHROME_APP_LIST_ITEM_H_
> +#define CHROME_BROWSER_UI_ASH_APP_**LIST_CHROME_APP_LIST_ITEM_H_
>
>  #include "ui/app_list/app_list_item_**model.h"
>
> @@ -21,9 +21,7 @@ class ChromeAppListItem : public
> app_list::AppListItemModel {
>    // associated with this activation.
>    virtual void Activate(int event_flags) = 0;
>
> -  Type type() const {
> -    return type_;
> -  }
> +  Type type() const { return type_; }
>
>   protected:
>    explicit ChromeAppListItem(Type type) : type_(type) {}
> @@ -35,4 +33,4 @@ class ChromeAppListItem : public
> app_list::AppListItemModel {
>    DISALLOW_COPY_AND_ASSIGN(**ChromeAppListItem);
>  };
>
> -#endif  // CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_CHROME_APP_LIST_ITEM_**
> H_
> +#endif  // CHROME_BROWSER_UI_ASH_APP_**LIST_CHROME_APP_LIST_ITEM_H_
> Index: chrome/browser/ui/ash/app_**list/extension_app_item.h
> diff --git a/chrome/browser/ui/ash/app_**list/extension_app_item.h
> b/chrome/browser/ui/ash/app_**list/extension_app_item.h
> index 800cf2e266d5a51c1e185a0bafa1c1**e27a3d558f..**
> 2ca5fb58b0bb19816b18b67c895a6c**1b1984315d 100644
> --- a/chrome/browser/ui/ash/app_**list/extension_app_item.h
> +++ b/chrome/browser/ui/ash/app_**list/extension_app_item.h
> @@ -2,8 +2,8 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_EXTENSION_APP_ITEM_H_
> -#define CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_EXTENSION_APP_ITEM_H_
> +#ifndef CHROME_BROWSER_UI_ASH_APP_**LIST_EXTENSION_APP_ITEM_H_
> +#define CHROME_BROWSER_UI_ASH_APP_**LIST_EXTENSION_APP_ITEM_H_
>
>  #include <string>
>
> @@ -71,4 +71,4 @@ class ExtensionAppItem : public ChromeAppListItem,
>    DISALLOW_COPY_AND_ASSIGN(**ExtensionAppItem);
>  };
>
> -#endif  // CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_EXTENSION_APP_ITEM_H_
> +#endif  // CHROME_BROWSER_UI_ASH_APP_**LIST_EXTENSION_APP_ITEM_H_
> Index: chrome/browser/ui/ash/app_**list/search_builder.h
> diff --git a/chrome/browser/ui/ash/app_**list/search_builder.h
> b/chrome/browser/ui/ash/app_**list/search_builder.h
> index fb036daf8f19e1b8cd19e2be449a83**cd7b97052a..**
> 4127d0f7a83e29a320c5d84ac8e232**9fd95971ad 100644
> --- a/chrome/browser/ui/ash/app_**list/search_builder.h
> +++ b/chrome/browser/ui/ash/app_**list/search_builder.h
> @@ -2,8 +2,8 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_SEARCH_BUILDER_H_
> -#define CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_SEARCH_BUILDER_H_
> +#ifndef CHROME_BROWSER_UI_ASH_APP_**LIST_SEARCH_BUILDER_H_
> +#define CHROME_BROWSER_UI_ASH_APP_**LIST_SEARCH_BUILDER_H_
>
>  #include "base/basictypes.h"
>  #include "base/memory/ref_counted.h"
> @@ -58,4 +58,4 @@ class SearchBuilder : public
> AutocompleteControllerDelegate {
>    DISALLOW_COPY_AND_ASSIGN(**SearchBuilder);
>  };
>
> -#endif  // CHROME_BROWSER_UI_VIEWS_ASH_**APP_LIST_SEARCH_BUILDER_H_
> +#endif  // CHROME_BROWSER_UI_ASH_APP_**LIST_SEARCH_BUILDER_H_
>
>
>

Powered by Google App Engine
This is Rietveld 408576698