Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 10823193: Move MediaGalleries.getMediaFileSystems back to experimental for M22 (Closed)

Created:
8 years, 4 months ago by vandebo (ex-Chrome)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move MediaGalleries.getMediaFileSystems back to experimental for M22 BUG=110823 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -595 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/experimental_media_galleries.idl View 1 chunk +27 lines, -0 lines 0 comments Download
D chrome/common/extensions/api/media_galleries.idl View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/common/extensions/docs/apps/api_index.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/apps/experimental.mediaGalleries.html View 5 chunks +198 lines, -6 lines 0 comments Download
D chrome/common/extensions/docs/apps/mediaGalleries.html View 1 chunk +0 lines, -441 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/extensions/samples.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 2 chunks +1 line, -1 line 0 comments Download
A + chrome/common/extensions/docs/static/experimental.mediaGalleries.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/common/extensions/docs/static/mediaGalleries.html View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js View 2 chunks +18 lines, -1 line 0 comments Download
D chrome/renderer/resources/extensions/media_galleries_custom_bindings.js View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_access/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_galleries/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/no_galleries/test.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/read_access/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/read_access/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
vandebo (ex-Chrome)
8 years, 4 months ago (2012-08-06 21:47:37 UTC) #1
Evan Stade
lgtm
8 years, 4 months ago (2012-08-06 22:29:34 UTC) #2
vandebo (ex-Chrome)
+asargent for extension review +thestig for chrome/renderer/renderer_resources.grd
8 years, 4 months ago (2012-08-06 22:31:29 UTC) #3
Lei Zhang
.grd change LGTM
8 years, 4 months ago (2012-08-06 22:44:34 UTC) #4
asargent_no_longer_on_chrome
LGTM
8 years, 4 months ago (2012-08-06 23:04:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10823193/1
8 years, 4 months ago (2012-08-06 23:05:48 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 23:05:55 UTC) #7
Presubmit check for 10823193-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to
chrome/common/extensions/docs/static/experimental.mediaGalleries.html not
reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

Presubmit checks took 1.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698