Temporarily disable buggy SSE2 code.

Temporarily disable buggy SSE2 code.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150335

[Tom Hudson, 2012-08-06 18:53:36]

Here's Stephen's suggested fix.

[aarya, 2012-08-06 19:00:05]

https://chromiumcodereview.appspot.com/10823186/diff/1/skia/ext/convolver.h
File skia/ext/convolver.h (right):

https://chromiumcodereview.appspot.com/10823186/diff/1/skia/ext/convolver.h#n...
skia/ext/convolver.h:18: //#define SIMD_SSE2 1
nit: Space after // and probably add a one-line comment.

[Tom Hudson, 2012-08-06 19:04:23]

reed@ requested tries; they're in-flight.

https://chromiumcodereview.appspot.com/10823186/diff/1/skia/ext/convolver.h
File skia/ext/convolver.h (right):

https://chromiumcodereview.appspot.com/10823186/diff/1/skia/ext/convolver.h#n...
skia/ext/convolver.h:18: //#define SIMD_SSE2 1
On 2012/08/06 19:00:05, aarya wrote:
> nit: Space after // and probably add a one-line comment.

Done.

[epoger, 2012-08-06 19:24:56]

LGTM (pending trybot results)

[Tom Hudson, 2012-08-06 20:29:09]

First set of tries are done except for chromeos, and I don't see anything there
that looks like our fault.

[reed1, 2012-08-06 20:54:26]

lgtm

[commit-bot: I haz the power, 2012-08-06 20:54:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tomhudson@chromium.org/10823186/4

[commit-bot: I haz the power, 2012-08-06 22:38:05]

Try job failure for 10823186-4 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-06 22:49:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tomhudson@chromium.org/10823186/4

[commit-bot: I haz the power, 2012-08-06 23:25:26]

Try job failure for 10823186-4 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[tomhudson, 2012-08-07 10:51:36]

On 2012/08/06 23:25:26, I haz the power (commit-bot) wrote:
> Try job failure for 10823186-4 (retry) on linux_chromeos for step "compile"
> (clobber build).

CQ failure is in a unit test not related to this patch; trying again.

[commit-bot: I haz the power, 2012-08-07 10:51:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tomhudson@chromium.org/10823186/4

[commit-bot: I haz the power, 2012-08-07 12:51:53]

Change committed as 150335