Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: chrome/browser/chromeos/gdata/gdata_contacts_service.h

Issue 10823182: contacts: Rate-limit GData photo requests and handle 404s. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_contacts_service.h
diff --git a/chrome/browser/chromeos/gdata/gdata_contacts_service.h b/chrome/browser/chromeos/gdata/gdata_contacts_service.h
index faf4434ead919d37ceb8a11e4b3dc0fbf5d83dcd..bec9835cb1a08a63002c726a4d0fdfdc4fb01b01 100644
--- a/chrome/browser/chromeos/gdata/gdata_contacts_service.h
+++ b/chrome/browser/chromeos/gdata/gdata_contacts_service.h
@@ -68,8 +68,8 @@ class GDataContactsService : public GDataContactsServiceInterface {
GDataAuthService* auth_service_for_testing();
- void set_max_simultaneous_photo_downloads_for_testing(int max_downloads) {
- max_simultaneous_photo_downloads_ = max_downloads;
+ void set_max_photo_downloads_per_second_for_testing(int max_downloads) {
+ max_photo_downloads_per_second_ = max_downloads;
}
void set_feed_url_for_testing(const GURL& url) {
feed_url_for_testing_ = url;
@@ -103,9 +103,9 @@ class GDataContactsService : public GDataContactsServiceInterface {
// member.
GURL feed_url_for_testing_;
- // Maximum number of photos we'll try to download at once (per
+ // Maximum number of photos we'll try to download per second (per
// DownloadContacts() request).
- int max_simultaneous_photo_downloads_;
+ int max_photo_downloads_per_second_;
// Callback that's invoked to rewrite photo URLs for tests.
// This is needed for tests that serve static feed data from a host/port

Powered by Google App Engine
This is Rietveld 408576698