Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823173: Handle null or empty page normalized string. (Closed)

Created:
8 years, 4 months ago by Robert Toscano
Modified:
8 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, arv (Not doing code reviews), Albert Bodenhamer
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Handle null or empty page normalized string. BUG=133766 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/print_preview/previewarea/preview_area.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Toscano
This fix will basically skip transformation of the preview if the string is empty or ...
8 years, 4 months ago (2012-08-03 23:37:02 UTC) #1
Lei Zhang
lgtm
8 years, 4 months ago (2012-08-04 02:18:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@google.com/10823173/1
8 years, 4 months ago (2012-08-04 02:19:01 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 04:51:48 UTC) #4 
Change committed as 150017

Powered by Google App Engine
This is Rietveld 408576698