Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 10823167: Revert "Add an IPC for PNaCl to check if the session is incognito," (Closed)

Created:
8 years, 4 months ago by jvoung (off chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org, ihf+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert "Add an IPC for PNaCl to check if the session is incognito," This reverts commit 0a3abb8418affb13cfc7b848ef69ce867ccaaad7. This is breaking the pnacl_bad_browser_test on Windows (some how the NaCl plugin itself fails to load for that test). BUG= http://code.google.com/p/nativeclient/issues/detail?id=2683 TBR=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -265 lines) Patch
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 4 chunks +1 line, -8 lines 0 comments Download
M ppapi/api/private/finish_writing_these/ppb_nacl_private.idl View 2 chunks +6 lines, -10 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 2 chunks +1 line, -4 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/local_temp_file.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h View 5 chunks +30 lines, -45 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 12 chunks +69 lines, -166 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/temporary_file.h View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/temporary_file.cc View 1 chunk +4 lines, -19 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698