Issue 10823165: Fixes bug where tabstrip won't correctly enter into stacking mode on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823165: Fixes bug where tabstrip won't correctly enter into stacking mode on (Closed)

Created:
8 years, 4 months ago by sky

Modified:
8 years, 4 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes bug where tabstrip won't correctly enter into stacking mode on touch. BUG=128741 TEST=see bug R=sadrul@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149971

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/tabs/tab_strip.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM http://codereview.chromium.org/10823165/diff/1/chrome/browser/ui/views/tabs/tab_strip.cc File chrome/browser/ui/views/tabs/tab_strip.cc (right): http://codereview.chromium.org/10823165/diff/1/chrome/browser/ui/views/tabs/tab_strip.cc#newcode1027 chrome/browser/ui/views/tabs/tab_strip.cc:1027: if (event.type() == ui::ET_GESTURE_BEGIN) Is it necessary to ...

8 years, 4 months ago (2012-08-03 21:38:03 UTC) #2

sky

On 2012/08/03 21:38:03, sadrul wrote: > LGTM > > http://codereview.chromium.org/10823165/diff/1/chrome/browser/ui/views/tabs/tab_strip.cc > File chrome/browser/ui/views/tabs/tab_strip.cc (right): > ...

8 years, 4 months ago (2012-08-03 22:20:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10823165/1

8 years, 4 months ago (2012-08-03 22:21:46 UTC) #4

Change committed as 149971

Expand Messages | Collapse Messages