Prettify Mac names, rewrite getDisplayPath API call to focus on $HOME

base/mac/foundation_util.h

Index: base/mac/foundation_util.h
diff --git a/base/mac/foundation_util.h b/base/mac/foundation_util.h
index ae4f03f7af8d8612564969727e03c04b4a4e8cf1..d517d95d454f97f45d07de6e59529a92df98f0a9 100644
--- a/base/mac/foundation_util.h
+++ b/base/mac/foundation_util.h
@@ -85,6 +85,10 @@ BASE_EXPORT bool GetLocalDirectory(NSSearchPathDirectory directory,
 BASE_EXPORT bool GetUserDirectory(NSSearchPathDirectory directory,
                                   FilePath* result);
 
+// Retrieves the localized display name for the base name of the given path.
+// If the path is not localized, this will just return the base name.

[Nico, 2012/09/04 14:09:37]

Why is this in base? It looks like it's only called in a single file, could it
be a static function in that file instead?

[thorogood, 2012/09/06 00:16:53]

Yes, it could! I have no strong opinions, but I believe this is a useful method
that meshes well with calls like "GetUserDirectory", which are all about user
folders such as Downloads, Desktop, etc..., and are most likely going to be
localized by the system.

[Nico, 2012/09/06 00:22:28]

I think we're trying to not add things to base that could conceivably be useful
elsewhere down the road. We're trying to keep base/ smallish.

[thorogood, 2012/09/06 04:42:37]

I've put this back into file_system_api.cc. Could you still PTAL from the Mac
point of view?

+BASE_EXPORT std::string GetDisplayBaseName(const FilePath& path);
+
 // Returns the ~/Library directory.
 BASE_EXPORT FilePath GetUserLibraryPath();