Prettify Mac names, rewrite getDisplayPath API call to focus on $HOME

base/mac/foundation_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MAC_FOUNDATION_UTIL_H_
 #define BASE_MAC_FOUNDATION_UTIL_H_
 
 #include <CoreFoundation/CoreFoundation.h>
 
 #include <string>
@@ skipping 67 matching lines @@
 // first found directory and returns true.  Otherwise, returns false.
 BASE_EXPORT bool GetLocalDirectory(NSSearchPathDirectory directory,
                                    FilePath* result);
 
 // Searches for directories for the given key in only the user domain.
 // If found, fills result (which must always be non-NULL) with the
 // first found directory and returns true.  Otherwise, returns false.
 BASE_EXPORT bool GetUserDirectory(NSSearchPathDirectory directory,
                                   FilePath* result);
 
+// Retrieves the localized display name for the given path.  If the path is not
+// localized, this will just retrieve the BaseName of the path.
+BASE_EXPORT std::string GetDisplayNameForPath(const FilePath& path);

[benwells, 2012/09/04 04:15:01]

Is this the display name for the whole path, or just for the base name?

[thorogood, 2012/09/04 05:57:33]

Just the base name. I've updated the comment to clarify.

[benwells, 2012/09/04 06:38:11]

More importantly can you change the name of the function?

[thorogood, 2012/09/04 06:45:43]

I've changed it to GetDisplayBaseNameForPath.

+
 // Returns the ~/Library directory.
 BASE_EXPORT FilePath GetUserLibraryPath();
 
 // Takes a path to an (executable) binary and tries to provide the path to an
 // application bundle containing it. It takes the outermost bundle that it can
 // find (so for "/Foo/Bar.app/.../Baz.app/..." it produces "/Foo/Bar.app").
 //   |exec_name| - path to the binary
 //   returns - path to the application bundle, or empty on error
 BASE_EXPORT FilePath GetAppBundlePath(const FilePath& exec_name);
 
@@ skipping 247 matching lines @@
 // by using the NSToCFCast methods above.
 // e.g. LOG(INFO) << base::mac::NSToCFCast(@"foo");
 // Operator << can not be overloaded for ObjectiveC types as the compiler
 // can not distinguish between overloads for id with overloads for void*.
 BASE_EXPORT extern std::ostream& operator<<(std::ostream& o,
                                             const CFErrorRef err);
 BASE_EXPORT extern std::ostream& operator<<(std::ostream& o,
                                             const CFStringRef str);
 
 #endif  // BASE_MAC_FOUNDATION_UTIL_H_