Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 10823151: Roll GYP to 1451. (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Roll GYP to 1451. Changes: r1449/r1450: Pass defines to midl.exe. r1447: ninja windows: Add build.ninja variable to turn on dep_database. r1448 was reverted in r1451. BUG=140324 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149792

Patch Set 1 #

Patch Set 2 : Make it r1451. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
Please take a look.
8 years, 4 months ago (2012-08-02 23:01:05 UTC) #1
scottmg
Nico likes a list of what the changes were for the range from https://code.google.com/p/gyp/source/list With ...
8 years, 4 months ago (2012-08-02 23:02:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10823151/7002
8 years, 4 months ago (2012-08-03 01:09:53 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 02:56:47 UTC) #4
Change committed as 149792

Powered by Google App Engine
This is Rietveld 408576698