Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10823149: Remove WebAuthFlowWindow and its implementation on all platforms. We don't need it anymore since we… (Closed)

Created:
8 years, 4 months ago by Munjal (Google)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Remove WebAuthFlowWindow and its implementation on all platforms. We don't need it anymore since we now use browser popups. TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -418 lines) Patch
D chrome/browser/ui/cocoa/extensions/web_auth_flow_window_cocoa.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/cocoa/extensions/web_auth_flow_window_cocoa.mm View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/ui/extensions/web_auth_flow_window.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/ui/extensions/web_auth_flow_window.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/ui/gtk/extensions/web_auth_flow_window_gtk.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/gtk/extensions/web_auth_flow_window_gtk.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/ui/views/extensions/web_auth_flow_window_views.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/views/extensions/web_auth_flow_window_views.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Munjal (Google)
8 years, 4 months ago (2012-08-02 21:52:23 UTC) #1
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-08-02 23:04:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10823149/1
8 years, 4 months ago (2012-08-02 23:18:35 UTC) #3
commit-bot: I haz the power
Presubmit check for 10823149-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-02 23:18:41 UTC) #4
Munjal (Google)
ben@ for OWNERS in chrome/
8 years, 4 months ago (2012-08-02 23:43:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10823149/1
8 years, 4 months ago (2012-08-02 23:47:15 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-03 00:53:58 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 01:35:22 UTC) #8
Change committed as 149774

Powered by Google App Engine
This is Rietveld 408576698