Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10823146: IntentHelper fix for chooser activity (Closed)

Created:
8 years, 4 months ago by aruslan
Modified:
8 years, 4 months ago
Reviewers:
Ted C, Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

IntentHelper fix for chooser activity FLAG_ACTIVITY_NEW_TASK is added as the chooser activity starts outside the main activity. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/IntentHelper.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
aruslan
Please help with the review.
8 years, 4 months ago (2012-08-02 17:09:57 UTC) #1
Ted C
lgtm
8 years, 4 months ago (2012-08-02 17:26:20 UTC) #2
Nico
lgtm Maybe chrome/android should have an OWNERS file?
8 years, 4 months ago (2012-08-02 18:21:16 UTC) #3
aruslan
Thanks for the review! Yes, I believe it should.
8 years, 4 months ago (2012-08-02 18:22:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/10823146/1
8 years, 4 months ago (2012-08-02 18:22:58 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 20:01:59 UTC) #6
Change committed as 149684

Powered by Google App Engine
This is Rietveld 408576698