chrome/common/extensions/extension.cc - Issue 10823143: Make the getAttention badge grey.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10823143: Make the getAttention badge grey. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move the Grant/Appearance code into the switch Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 2fe50b27c25987ab3189c7d0c669e23b6ec29236..f3ddfc78fe584c3dd0cb5fa4c3aed0451db6629d 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -808,8 +808,9 @@ scoped_ptr<ExtensionAction> Extension::LoadExtensionActionHelper(

// Page/script actions are hidden/disabled by default, and browser actions are

// visible/enabled by default.

- result->SetIsVisible(ExtensionAction::kDefaultTabId,

- action_type == ExtensionAction::TYPE_BROWSER);

+ result->SetAppearance(ExtensionAction::kDefaultTabId,

+ action_type == ExtensionAction::TYPE_BROWSER ?

+ ExtensionAction::ACTIVE : ExtensionAction::INVISIBLE);

if (manifest_version_ == 1) {

const ListValue* icons = NULL;