chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc - Issue 10823143: Make the getAttention badge grey.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc

Issue 10823143: Make the getAttention badge grey. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move the Grant/Appearance code into the switch Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_actions_api.cc ('k') | chrome/browser/extensions/script_badge_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc

index 8236a84a675f729de820e9e4eab388dc7a0088c0..eff7b16302a4dd324f1e3e58ddbd2e124abf38f9 100644

--- a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc

@@ -95,7 +95,8 @@ bool PageActionsFunction::SetPageActionEnabled(bool enable) {

}

// Set visibility and broadcast notifications that the UI should be updated.

- page_action->SetIsVisible(tab_id, enable);

+ page_action->SetAppearance(

+ tab_id, enable ? ExtensionAction::ACTIVE : ExtensionAction::INVISIBLE);

page_action->SetTitle(tab_id, title);

page_action->SetIconIndex(tab_id, icon_id);

contents->extension_tab_helper()->location_bar_controller()->NotifyChange();