chrome/browser/extensions/api/extension_action/extension_actions_api.cc - Issue 10823143: Make the getAttention badge grey.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

Issue 10823143: Make the getAttention badge grey. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move the Grant/Appearance code into the switch Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

index 4792737619d263421385199dc63ef87102cc40ec..975fc6f72d8163ba9f0be37807f90050705dd97b 100644

--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

@@ -182,7 +182,8 @@ bool ExtensionActionFunction::ParseCSSColorString(

}

bool ExtensionActionFunction::SetVisible(bool visible) {

- extension_action_->SetIsVisible(tab_id_, visible);

+ extension_action_->SetAppearance(

+ tab_id_, visible ? ExtensionAction::ACTIVE : ExtensionAction::INVISIBLE);

NotifyChange();

return true;

}

« no previous file with comments | « no previous file | chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc » ('j') | no next file with comments »