Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: media/mp4/box_reader.h

Issue 10823139: Set error on unrecognized top-level BMFF boxes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove FourCCs used only for testing Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/mp4/box_reader.cc » ('j') | media/mp4/box_reader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mp4/box_reader.h
diff --git a/media/mp4/box_reader.h b/media/mp4/box_reader.h
index 1898c73a2ee4c7935a3d4f183eabd1ab6eb5801e..211d99ac6109cb2cb58bf904570343834f53a518 100644
--- a/media/mp4/box_reader.h
+++ b/media/mp4/box_reader.h
@@ -91,6 +91,11 @@ class MEDIA_EXPORT BoxReader : public BufferReader {
int* box_size,
bool* err) WARN_UNUSED_RESULT;
+ // Returns true if |type| is recognized to be a top-level box, false
+ // otherwise. This returns true for some boxes which we do not parse.
+ // Helpful in debugging misaligned appends.
+ static bool IsValidTopLevelBox(const FourCC& type);
+
// Scan through all boxes within the current box, starting at the current
// buffer position. Must be called before any of the *Child functions work.
bool ScanChildren() WARN_UNUSED_RESULT;
« no previous file with comments | « no previous file | media/mp4/box_reader.cc » ('j') | media/mp4/box_reader.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698