1. Add test for https://src.chromium.org/viewvc/chrome?view=rev&revision=149541

1. Add test for https://src.chromium.org/viewvc/chrome?view=rev&revision=149541
2. Fixed another bug in CustomHistogram ranges counting

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150020

[jar (doing other things), 2012-08-03 21:53:42]

With nits below changed...
LGTM

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram.cc
File base/metrics/histogram.cc (right):

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram.cc#newc...
base/metrics/histogram.cc:886: int valid_ranges = 0;
Suggest use boolean:
bool valid_ranges = false;

then set where you would increment.

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram.cc#newc...
base/metrics/histogram.cc:888: Sample s = custom_ranges[i];
nit: (on existing code): Please use |sample| instead of s

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram_unittes...
File base/metrics/histogram_unittest.cc (right):

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram_unittes...
base/metrics/histogram_unittest.cc:330: Histogram::kNoFlags);
nit: consider wrapping on only two lines.

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram_unittes...
base/metrics/histogram_unittest.cc:367: "");
nit: Suggest:
 EXPECT_DEATH(CustomHistogram::FactoryGet("BadRangesCustom2", custom_ranges,
                                          Histogram::kNoFlags),
              "");

[kaiwang, 2012-08-03 22:15:53]

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram.cc
File base/metrics/histogram.cc (right):

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram.cc#newc...
base/metrics/histogram.cc:886: int valid_ranges = 0;
On 2012/08/03 21:53:42, jar wrote:
> Suggest use boolean:
> bool valid_ranges = false;
> 
> then set where you would increment.

Done.

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram.cc#newc...
base/metrics/histogram.cc:888: Sample s = custom_ranges[i];
On 2012/08/03 21:53:42, jar wrote:
> nit: (on existing code): Please use |sample| instead of s

Done.

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram_unittes...
File base/metrics/histogram_unittest.cc (right):

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram_unittes...
base/metrics/histogram_unittest.cc:330: Histogram::kNoFlags);
On 2012/08/03 21:53:42, jar wrote:
> nit: consider wrapping on only two lines.

Done.

http://codereview.chromium.org/10823137/diff/1/base/metrics/histogram_unittes...
base/metrics/histogram_unittest.cc:367: "");
On 2012/08/03 21:53:42, jar wrote:
> nit: Suggest:
>  EXPECT_DEATH(CustomHistogram::FactoryGet("BadRangesCustom2", custom_ranges,
>                                           Histogram::kNoFlags),
>               "");

Done.

[commit-bot: I haz the power, 2012-08-03 22:17:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10823137/13001

[commit-bot: I haz the power, 2012-08-03 22:47:43]

Try job failure for 10823137-13001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-04 03:29:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10823137/13001

[commit-bot: I haz the power, 2012-08-04 06:23:04]

Change committed as 150020