Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10823130: [Mac] Position the avatar and fullscreen buttons when adding the first profile. (Closed)

Created:
8 years, 4 months ago by Robert Sesek
Modified:
8 years, 4 months ago
Reviewers:
sail
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Mac] Position the avatar and fullscreen buttons when adding the first profile. BUG=138586 TEST=On Lion or higher, run with a fresh profile. Go to settings and add a new profile. The avatar button in the original window is to the right of the fullscreen button. TBR=gyp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149559

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/browser/avatar_button_controller.mm View 1 2 chunks +15 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 1 chunk +100 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Robert Sesek
8 years, 4 months ago (2012-08-01 23:38:34 UTC) #1
sail
LGTM Awesome test! https://chromiumcodereview.appspot.com/10823130/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right): https://chromiumcodereview.appspot.com/10823130/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm#newcode43 chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:43: // Declare a private 10.7+ private ...
8 years, 4 months ago (2012-08-02 00:12:40 UTC) #2
Robert Sesek
https://chromiumcodereview.appspot.com/10823130/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right): https://chromiumcodereview.appspot.com/10823130/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm#newcode43 chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:43: // Declare a private 10.7+ private API. On 2012/08/02 ...
8 years, 4 months ago (2012-08-02 00:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10823130/8002
8 years, 4 months ago (2012-08-02 00:24:22 UTC) #4
commit-bot: I haz the power
Presubmit check for 10823130-8002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-02 00:24:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10823130/8002
8 years, 4 months ago (2012-08-02 00:25:02 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 01:55:18 UTC) #7
Change committed as 149559

Powered by Google App Engine
This is Rietveld 408576698