Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 10823122: Update ChromeVox manifest to use the version 2 manifest. (Closed)

Created:
8 years, 4 months ago by dmazzoni
Modified:
8 years, 4 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Update ChromeVox manifest to use the version 2 manifest. BUG=none TBR=zelidrag Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/access_chromevox/manifest.json View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
8 years, 4 months ago (2012-08-01 18:57:35 UTC) #1
David Tseng
lgtm On Wed, Aug 1, 2012 at 11:57 AM, <dmazzoni@chromium.org> wrote: > Reviewers: David Tseng, ...
8 years, 4 months ago (2012-08-03 23:09:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10823122/1
8 years, 4 months ago (2012-08-03 23:27:53 UTC) #3
commit-bot: I haz the power
Presubmit check for 10823122-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-03 23:27:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10823122/1
8 years, 4 months ago (2012-08-04 05:48:36 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-04 07:27:35 UTC) #6
Change committed as 150021

Powered by Google App Engine
This is Rietveld 408576698