Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: chrome/browser/resources/file_manager/js/file_transfer_controller.js

Issue 10823119: Enable drag and drop on breadcrumbs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_transfer_controller.js
diff --git a/chrome/browser/resources/file_manager/js/file_transfer_controller.js b/chrome/browser/resources/file_manager/js/file_transfer_controller.js
index ec8485de9d579c3f8dcf8502d5aef6cff0dfecc9..5bb661776c81d1f57c75743602b79cb4c7b94113 100644
--- a/chrome/browser/resources/file_manager/js/file_transfer_controller.js
+++ b/chrome/browser/resources/file_manager/js/file_transfer_controller.js
@@ -71,14 +71,15 @@ FileTransferController.prototype = {
!!opt_onlyIntoDirectories));
},
- attachBreadcrumbsDropTarget: function(breadcrumbs) {
- breadcrumbs.addEventListener('dragover',
+ attachBreadcrumbsDropTarget: function(breadcrumbsController) {
+ var container = breadcrumbsController.getContainer();
+ container.addEventListener('dragover',
this.onDragOver_.bind(this, true, null));
- breadcrumbs.addEventListener('dragenter',
- this.onDragEnterBreadcrumbs_.bind(this, breadcrumbs));
- breadcrumbs.addEventListener('dragleave',
+ container.addEventListener('dragenter',
+ this.onDragEnterBreadcrumbs_.bind(this, breadcrumbsController));
+ container.addEventListener('dragleave',
this.onDragLeave_.bind(this, null));
- breadcrumbs.addEventListener('drop', this.onDrop_.bind(this, true));
+ container.addEventListener('drop', this.onDrop_.bind(this, true));
},
/**
@@ -268,20 +269,12 @@ FileTransferController.prototype = {
}
},
- onDragEnterBreadcrumbs_: function(breadcrumbs, event) {
- if (!event.target.classList.contains('breadcrumb-path'))
+ onDragEnterBreadcrumbs_: function(breadcrumbsContainer, event) {
+ var path = breadcrumbsContainer.getTargetPath(event);
+ if (!path)
return;
- this.dragEnterCount_++;
-
- var items = breadcrumbs.querySelectorAll('.breadcrumb-path');
- var path = this.directoryModel_.getCurrentRootPath();
-
- if (event.target != items[0]) {
- for (var i = 1; items[i - 1] != event.target; i++) {
- path += '/' + items[i].textContent;
- }
- }
+ this.dragEnterCount_++;
this.setDropTarget_(event.target, true, event.dataTransfer, path);
},

Powered by Google App Engine
This is Rietveld 408576698