Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 10823119: Enable drag and drop on breadcrumbs (Closed)

Created:
8 years, 4 months ago by SeRya
Modified:
8 years, 4 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Enable drag and drop on breadcrumbs BUG=137983 TEST=Manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149442

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -24 lines) Patch
M chrome/browser/resources/file_manager/js/breadcrumbs_controller.js View 4 chunks +39 lines, -6 lines 2 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_transfer_controller.js View 2 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
SeRya
8 years, 4 months ago (2012-08-01 14:24:55 UTC) #1
Oleg Eterevsky
lgtm https://chromiumcodereview.appspot.com/10823119/diff/1/chrome/browser/resources/file_manager/js/breadcrumbs_controller.js File chrome/browser/resources/file_manager/js/breadcrumbs_controller.js (right): https://chromiumcodereview.appspot.com/10823119/diff/1/chrome/browser/resources/file_manager/js/breadcrumbs_controller.js#newcode214 chrome/browser/resources/file_manager/js/breadcrumbs_controller.js:214: for (var i = 1; items[i - 1] ...
8 years, 4 months ago (2012-08-01 14:56:52 UTC) #2
SeRya
https://chromiumcodereview.appspot.com/10823119/diff/1/chrome/browser/resources/file_manager/js/breadcrumbs_controller.js File chrome/browser/resources/file_manager/js/breadcrumbs_controller.js (right): https://chromiumcodereview.appspot.com/10823119/diff/1/chrome/browser/resources/file_manager/js/breadcrumbs_controller.js#newcode214 chrome/browser/resources/file_manager/js/breadcrumbs_controller.js:214: for (var i = 1; items[i - 1] != ...
8 years, 4 months ago (2012-08-01 15:23:43 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-01 15:23:49 UTC) #4
SeRya
Vlad, I need valid owner's review.
8 years, 4 months ago (2012-08-01 15:39:49 UTC) #5
Vladislav Kaznacheev
lgtm
8 years, 4 months ago (2012-08-01 16:01:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10823119/1
8 years, 4 months ago (2012-08-01 16:09:25 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 17:50:58 UTC) #8
Change committed as 149442

Powered by Google App Engine
This is Rietveld 408576698