Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 10823116: Add a svn:executable flag. (Closed)

Created:
8 years, 4 months ago by Hironori Bono
Modified:
8 years, 4 months ago
Reviewers:
Russ Harmon
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Add a svn:executable flag. This change adds a svn:executable flag to a python script. TBR=eatnumber BUG=none TEST=check_perms Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
M chrome/test/functional/tracing/pyauto_tracing.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
8 years, 4 months ago (2012-08-01 03:53:56 UTC) #1
Russ Harmon
On 2012/08/01 03:53:56, Hironori Bono wrote: Why does this need to be executable? It's not ...
8 years, 4 months ago (2012-08-01 08:18:37 UTC) #2
Hironori Bono
Greetings, If I recall correctly, check_perms.py treats a file whose first line starts with "#!" ...
8 years, 4 months ago (2012-08-01 08:34:19 UTC) #3
Russ Harmon
On 2012/08/01 08:34:19, Hironori Bono wrote: > Greetings, > > If I recall correctly, check_perms.py ...
8 years, 4 months ago (2012-08-01 18:01:08 UTC) #4
Nirnimesh
pyauto_tracing.py is modeled on pyauto_functional.py right? In that case it should be executable. You can ...
8 years, 4 months ago (2012-08-01 18:06:49 UTC) #5
Russ Harmon
8 years, 4 months ago (2012-08-01 18:07:36 UTC) #6
On 2012/08/01 18:06:49, Nirnimesh wrote:
> pyauto_tracing.py is modeled on pyauto_functional.py right?
> In that case it should be executable. You can run your test as:
> $ python pyauto_tracing.py tracing_smoke_test

Ah, I hadn't realized that. Yeah, this is correct then. LGTM

Powered by Google App Engine
This is Rietveld 408576698