Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 10823114: [Mac] When creating a HistoryMenuBridge, manually poke the TabRestoreService if already loaded. (Closed)

Created:
8 years, 4 months ago by Robert Sesek
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] When creating a HistoryMenuBridge, manually poke the TabRestoreService if already loaded. The issue was that when AppController deleted and recreated the Bridge, the TabRestoreService was already loaded and the Changed observer notification was never fired. That notification builds the "Recently Closed" section. If the backend is loaded on construction, invoke the method manually. BUG=124647 TEST=Have two Chrome profiles. Open three different tabs in each profile. Close one or two in each. Switch between the windows and the "Recently Closed" section of the "History" menu reflects the tabs that were closed in each profile window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
8 years, 4 months ago (2012-07-31 22:17:11 UTC) #1
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-01 16:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10823114/1
8 years, 4 months ago (2012-08-01 16:16:51 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 18:07:59 UTC) #4
Change committed as 149446

Powered by Google App Engine
This is Rietveld 408576698