net: disable SSL compression

net: disable SSL compression

This change also updates the page-info dialog to assume that compression isn't
used. It doesn't, however, remove the message from the .grd file in order to
make this change easier to merge.

BUG=139744
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149672

[wtc, 2012-08-01 17:31:28]

Patch set 1 LGTM.

http://codereview.chromium.org/10823111/diff/1/chrome/browser/page_info_model.cc
File chrome/browser/page_info_model.cc (left):

http://codereview.chromium.org/10823111/diff/1/chrome/browser/page_info_model...
chrome/browser/page_info_model.cc:255:
IDS_PAGE_INFO_SECURITY_TAB_NO_COMPRESSION);

Just to doublecheck: if TLS compression is not used, you
don't want the page info model to say that.  Correct?

[agl, 2012-08-01 23:04:59]

http://codereview.chromium.org/10823111/diff/1/chrome/browser/page_info_model.cc
File chrome/browser/page_info_model.cc (left):

http://codereview.chromium.org/10823111/diff/1/chrome/browser/page_info_model...
chrome/browser/page_info_model.cc:255:
IDS_PAGE_INFO_SECURITY_TAB_NO_COMPRESSION);
On 2012/08/01 17:31:28, wtc wrote:
> 
> Just to doublecheck: if TLS compression is not used, you
> don't want the page info model to say that.  Correct?

Yes. It seems silly to mention that the connection is not compressed if we don't
support it. In the future we'll probably want to clean this up but I don't want
to make this patch hard to merge.

[commit-bot: I haz the power, 2012-08-01 23:05:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/10823111/1

[commit-bot: I haz the power, 2012-08-01 23:05:23]

Presubmit check for 10823111-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 4.1s to calculate.