Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823107: Do not set ANDROID_SDK_ROOT so it uses default from android_tools. (Closed)

Created:
8 years, 4 months ago by navabi
Modified:
8 years, 4 months ago
Reviewers:
cmp, Yaron, Isaac (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Do not set ANDROID_SDK_ROOT so it uses default from android_tools. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/buildbot_functions.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
navabi
8 years, 4 months ago (2012-07-31 18:34:06 UTC) #1
Yaron
lgtm I guess we need your other patch to land and then see a try ...
8 years, 4 months ago (2012-07-31 18:36:52 UTC) #2
navabi
Right. The other CL (https://chromiumcodereview.appspot.com/10829091/) is in the CQ now. Will submit this to the ...
8 years, 4 months ago (2012-07-31 18:43:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/10823107/1
8 years, 4 months ago (2012-07-31 20:06:00 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 21:29:16 UTC) #5 
Change committed as 149280

Powered by Google App Engine
This is Rietveld 408576698