Extensions Docs Server: Preview server and more integration tests

Extensions Docs Server: Preview server and more integration tests

We now have a small preview server that can be run without App Engine. I also
made some fixes to the integration tests.

BUG=131095
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149285

[cduvall, 2012-07-31 17:56:07]

Some fixes to the integration test that you suggested and a preview server.

[not at google - send to devlin, 2012-07-31 21:34:40]

Nice one. Extremely cool. lgtm so that it's in for tomorrow.

One thing I was thinking -- people don't know about previewserver.py in JSC,
possibly because it has a name like previewserver.py. What do you think about
just calling it "preview.py"? It has a nice ring to it, as an analogy to
"build.py".

Btw what's with the keybindings/commands changes?

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/previewserver.py (right):

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:5: 
comment plz. People will probably open up this file to see what it does, you
want a nice comment advertising it.

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:36: Handler(request,
response, local_path='../..').get()
It's equally likely that this script will be run from the chromium base
directory (src/). You can probably figure out what this should be based on
whatever $0 shows up as in Python.

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:37: if
os.path.splitext(parsed_url.path)[-1] in ['.png', '.gif', '.jpeg']:
is the difference here in encoding? like, should this be a check for
isinstance(response.out.getvalue(), str)?

(assuming so, save response.out.getvalue() to local variable etc obviously)

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:40:
self.wfile.write(response.out.getvalue().encode('ascii', 'replace'))
utf8 would be more appropriate if it works? ascii would lose unicode
information.

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:60: except
KeyboardInterrupt:
"finally" would be a more appropriate idiom.

[cduvall, 2012-07-31 21:53:10]

I like the preview name. And the keybinding changes were because the API changed
names. And the wonderful integration test caught it :)

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/previewserver.py (right):

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:5: 
On 2012/07/31 21:34:40, kalman wrote:
> comment plz. People will probably open up this file to see what it does, you
> want a nice comment advertising it.

Done.

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:36: Handler(request,
response, local_path='../..').get()
On 2012/07/31 21:34:40, kalman wrote:
> It's equally likely that this script will be run from the chromium base
> directory (src/). You can probably figure out what this should be based on
> whatever $0 shows up as in Python.

Done.

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:37: if
os.path.splitext(parsed_url.path)[-1] in ['.png', '.gif', '.jpeg']:
On 2012/07/31 21:34:40, kalman wrote:
> is the difference here in encoding? like, should this be a check for
> isinstance(response.out.getvalue(), str)?
> 
> (assuming so, save response.out.getvalue() to local variable etc obviously)

Done.

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:40:
self.wfile.write(response.out.getvalue().encode('ascii', 'replace'))
On 2012/07/31 21:34:40, kalman wrote:
> utf8 would be more appropriate if it works? ascii would lose unicode
> information.

Done.

https://chromiumcodereview.appspot.com/10823105/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/previewserver.py:60: except
KeyboardInterrupt:
On 2012/07/31 21:34:40, kalman wrote:
> "finally" would be a more appropriate idiom.

Done.

[Aaron Boodman, 2012-08-01 04:44:23]

Doesn't README need to be updated?

Also, in general, can you update the README to explain how to update docs (like,
how to find your way around the directory structure?).