Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 10823099: Add login prompt dialog support for GTK content shell. (Closed)

Created:
8 years, 4 months ago by Shouqun Liu
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add login prompt dialog support for GTK content shell. - The GTK login prompt dialog is used for HTTP auth. Some websites need HTTP basic access authentication, then the login prompt dialog is required. BUG=90445 TEST=HTTP authentication websites tested TBR=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149395

Patch Set 1 #

Patch Set 2 : Rebase the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -2 lines) Patch
M content/content_shell.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_login_dialog.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/shell/shell_login_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
A content/shell/shell_login_dialog_gtk.cc View 1 chunk +111 lines, -0 lines 0 comments Download
M content/shell/shell_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Shouqun Liu
Hi, this patch add login prompt dialog support for GTK content shell, thanks for review!
8 years, 4 months ago (2012-07-31 14:16:49 UTC) #1
jochen (gone - plz use gerrit)
lgtm
8 years, 4 months ago (2012-07-31 14:28:47 UTC) #2
jam
gypi looks good, thanks
8 years, 4 months ago (2012-07-31 15:34:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10823099/1
8 years, 4 months ago (2012-07-31 15:38:22 UTC) #4
commit-bot: I haz the power
Presubmit check for 10823099-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 15:38:26 UTC) #5
Shouqun Liu
Hi jam, seems need your "lgtm"... thanks On 2012/07/31 15:34:38, John Abd-El-Malek wrote: > gypi ...
8 years, 4 months ago (2012-07-31 15:40:02 UTC) #6
jochen (gone - plz use gerrit)
On 2012/07/31 15:40:02, Shouqun Liu wrote: > Hi jam, seems need your "lgtm"... thanks > ...
8 years, 4 months ago (2012-08-01 08:20:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10823099/4002
8 years, 4 months ago (2012-08-01 08:42:27 UTC) #8
Shouqun Liu
On 2012/08/01 08:20:11, jochen wrote: > On 2012/07/31 15:40:02, Shouqun Liu wrote: > > Hi ...
8 years, 4 months ago (2012-08-01 08:43:30 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 10:11:07 UTC) #10
Change committed as 149395

Powered by Google App Engine
This is Rietveld 408576698