Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 10823088: Valgrind: Suppress a leak. Heapchecker: Re-enable test_shell_tests and unit_tests and see what happ… (Closed)

Created:
8 years, 4 months ago by Lei Zhang
Modified:
8 years, 4 months ago
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Valgrind: Suppress a leak. Heapchecker: Re-enable test_shell_tests and unit_tests and see what happens. BUG=132867, 139703 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M tools/heapcheck/test_shell_tests.gtest-heapcheck.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/heapcheck/unit_tests.gtest-heapcheck.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
unit_tests ran ok for me locally...
8 years, 4 months ago (2012-07-30 21:36:01 UTC) #1
Brad Chen
8 years, 4 months ago (2012-07-30 21:36:59 UTC) #2
LGTM

Let's keep an eye on the 'bots though...

Powered by Google App Engine
This is Rietveld 408576698